www

commit fb46d6d216bff93bb5da87566851d22c855c9fac
parent 73add2156dc38a4364ffbbeb3e8b150cc65bc027
Author: Dan Stillman <dstillman@zotero.org>
Date:   Fri, 20 Nov 2015 16:33:42 -0500

Merge pull request #873 from adomasven/feature/batch-untag

Remove tags on shift-drag
Diffstat:
M
chrome/content/zotero/bindings/tagselector.xml
 | 
13
++++++++++---

1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/chrome/content/zotero/bindings/tagselector.xml b/chrome/content/zotero/bindings/tagselector.xml
@@ -934,13 +934,16 @@
 							}
 						}
 						*/
-						
+
+						// Store the event, because drop event does not have shiftKey attribute set
+						Zotero.DragDrop.currentEvent = event;
 						event.target.setAttribute('draggedOver', true);
 						event.preventDefault();
-						event.effectAllowed = event.dropEffect = "link";
+						event.dataTransfer.dropEffect = "copy";
 					}
 					
 					this.onDragExit = function (event) {
+						Zotero.DragDrop.currentEvent = null;
 						event.target.setAttribute('draggedOver', false);
 					}
 					
@@ -962,7 +965,11 @@
 							
 							for (let i=0; i<items.length; i++) {
 								let item = items[i];
-								item.addTag(value);
+								if (Zotero.DragDrop.currentEvent.shiftKey) {
+									item.removeTag(value);
+								} else {
+									item.addTag(value);
+								}
 								yield item.save();
 							}
 						}.bind(this));