www

commit f3a6b41c1cc2239d5cb1c0e36442645b2e4d50ff
parent 15252623d77c24ac6852dcccc5292ef0d325ae58
Author: Dan Stillman <dstillman@zotero.org>
Date:   Fri, 29 May 2015 04:01:40 -0400

Add -f test flag to stop after first test failure

(Mocha has a 'bail' config flag that's supposed to do this, but it doesn't seem
to work when passed to mocha.setup() (maybe because we're setting a custom fail
handler?), so this just calls abort() on the runner manually.)

Diffstat:
M
test/components/zotero-unit.js
 | 
1
+
M
test/content/runtests.js
 | 
10
++++++++--
M
test/runtests.sh
 | 
10
+++++++++-

3 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/test/components/zotero-unit.js b/test/components/zotero-unit.js
@@ -33,6 +33,7 @@ ZoteroUnit.prototype = {
 	handle:function(cmdLine) {
 		this.tests = cmdLine.handleFlagWithParam("test", false);
 		this.noquit = cmdLine.handleFlag("noquit", false);
+		this.bail = cmdLine.handleFlag("bail", false);
 	},
 
 	dump:function(x) {
diff --git a/test/content/runtests.js b/test/content/runtests.js
@@ -22,7 +22,7 @@ function quit(failed) {
 }
 
 function Reporter(runner) {
-	var indents = 0, passed = 0, failed = 0;
+	var indents = 0, passed = 0, failed = 0, aborted = false;
 
 	function indent() {
 		return Array(indents).join('  ');
@@ -61,10 +61,16 @@ function Reporter(runner) {
 			+ " " + test.title + "\n"
 			+ indent() + "  " + err.toString() + " at\n"
 			+ indent() + "    " + err.stack.replace("\n", "\n" + indent() + "    ", "g"));
+		
+		if (ZoteroUnit.bail) {
+			aborted = true;
+			runner.abort();
+		}
 	});
 
 	runner.on('end', function() {
-		dump(passed+"/"+(passed+failed)+" tests passed.\n");
+		dump(passed + "/" + (passed + failed) + " tests passed"
+			+ (aborted ? " -- aborting" : "") + "\n");
 		quit(failed != 0);
 	});
 }
diff --git a/test/runtests.sh b/test/runtests.sh
@@ -29,13 +29,14 @@ Options
  -x FX_EXECUTABLE    path to Firefox executable (default: $FX_EXECUTABLE)
  -d                  enable debug logging
  -c                  open JavaScript console and don't quit on completion
+ -f                  stop after first test failure
  -b                  skip bundled translator/style installation
  TESTS               set of tests to run (default: all)
 DONE
 	exit 1
 }
 
-while getopts "x:dcb" opt; do
+while getopts "x:dcfb" opt; do
 	case $opt in
 		x)
 			FX_EXECUTABLE="$OPTARG"
@@ -46,6 +47,9 @@ while getopts "x:dcb" opt; do
         c)
             FX_ARGS="-jsconsole -noquit"
             ;;
+		f)
+			STOP_ON_FAILURE=true
+			;;
         b)
         	SKIP_BUNDLED=true
         	;;
@@ -101,6 +105,10 @@ if [ "$SKIP_BUNDLED" = true ]; then
 	FX_ARGS="$FX_ARGS -ZoteroSkipBundledFiles"
 fi
 
+if [ "$STOP_ON_FAILURE" = true ]; then
+	FX_ARGS="$FX_ARGS -bail"
+fi
+
 # Clean up on exit
 trap "{ rm -rf \"$PROFILE\"; }" EXIT