www

commit e643d85d2ca226053c00774497463dec63d92f3f
parent 0823b18c92ad31ad91e3fc6f7ae5497e1ea2df49
Author: Simon Kornblith <simon@simonster.com>
Date:   Tue, 27 Dec 2011 20:13:08 +0000

Get rid of for each

Diffstat:
M
chrome/content/zotero/xpcom/utilities.js
 | 
12
++++++++----

1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/chrome/content/zotero/xpcom/utilities.js b/chrome/content/zotero/xpcom/utilities.js
@@ -1329,8 +1329,10 @@ Zotero.Utilities = {
 		// map text fields
 		for(var variable in CSL_TEXT_MAPPINGS) {
 			if(variable in cslItem) {
-				for each(var field in CSL_TEXT_MAPPINGS[variable]) {
-					var fieldID = Zotero.ItemFields.getID(field);
+				var textMappings = CSL_TEXT_MAPPINGS[variable];
+				for(var i in textMappings) {
+					var field = textMappings[i],
+						fieldID = Zotero.ItemFields.getID(field);
 					if(Zotero.ItemFields.isBaseField(fieldID)) {
 						var newFieldID = Zotero.ItemFields.getFieldIDFromTypeAndBase(itemTypeID, fieldID);
 						if(newFieldID) fieldID = newFieldID;
@@ -1355,8 +1357,10 @@ Zotero.Utilities = {
 					creatorTypeID = Zotero.CreatorTypes.getPrimaryIDForType(itemTypeID);
 				}
 				
-				for each(var cslAuthor in cslItem[CSL_NAMES_MAPPINGS[field]]) {
-					var creator = isZoteroItem ? new Zotero.Creator() : {};
+				var nameMappings = cslItem[CSL_NAMES_MAPPINGS[field]];
+				for(var i in nameMappings) {
+					var cslAuthor = nameMappings[i],
+						creator = isZoteroItem ? new Zotero.Creator() : {};
 					if(cslAuthor.family || cslAuthor.given) {
 						if(cslAuthor.family) creator.lastName = cslAuthor.family;
 						if(cslAuthor.given) creator.firstName = cslAuthor.given;