commit e21a914a1fc2279b21746d9484b9cd7137fff628
parent 4c46ebcf96db54382f9279f58cdadd58bf4aadb1
Author: Dan Stillman <dstillman@zotero.org>
Date: Sat, 21 May 2016 15:52:48 -0400
Clarify comment for local object version updating behavior
Diffstat:
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/chrome/content/zotero/xpcom/sync/syncEngine.js b/chrome/content/zotero/xpcom/sync/syncEngine.js
@@ -940,10 +940,11 @@ Zotero.Sync.Data.Engine.prototype._uploadObjects = Zotero.Promise.coroutine(func
toCache.push(current);
}
else {
- // This won't reflect the actual version of the item on the server, but
- // it will guarantee that the item won't be redownloaded unnecessarily
- // in the case of a full sync, because the version will be higher than
- // whatever version is on the server.
+ // This won't necessarily reflect the actual version of the object on the server,
+ // since objects are uploaded in batches and we only get the final version, but it
+ // will guarantee that the item won't be redownloaded unnecessarily in the case of
+ // a full sync, because the version will be higher than whatever version is on the
+ // server.
batch[index].version = libraryVersion
toCache.push(batch[index]);
}