www

commit d868f007e92b65189517bb6dc05a7a5d20713c94
parent 5c523d869412cbf842377e711703c89d87cd5fb0
Author: Dan Stillman <dstillman@zotero.org>
Date:   Sun, 19 Jul 2015 17:08:36 -0400

Don't select new groups in collections pane

Diffstat:
M
chrome/content/zotero/xpcom/collectionTreeView.js
 | 
6
++----
M
test/tests/collectionTreeViewTest.js
 | 
6
++++++

2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/chrome/content/zotero/xpcom/collectionTreeView.js b/chrome/content/zotero/xpcom/collectionTreeView.js
@@ -431,12 +431,10 @@ Zotero.CollectionTreeView.prototype.notify = Zotero.Promise.coroutine(function* 
 				}
 				
 				break;
-				
+			
 			case 'group':
 				yield this.reload();
-				// Groups can only be created during sync
-				let libraryID = Zotero.Groups.getLibraryIDFromGroupID(id);
-				yield this.selectByID("L" + libraryID);
+				yield this.restoreSelection(currentTreeRow);
 				break;
 		}
 	}
diff --git a/test/tests/collectionTreeViewTest.js b/test/tests/collectionTreeViewTest.js
@@ -235,6 +235,12 @@ describe("Zotero.CollectionTreeView", function() {
 			}
 		})
 		
+		it("shouldn't select a new group", function* () {
+			var group = yield createGroup();
+			// Library should still be selected
+			assert.equal(cv.getSelectedLibraryID(), Zotero.Libraries.userLibraryID);
+		})
+		
 		it("should remove a group and all children", function* () {
 			// Make sure Group Libraries separator and header exist already,
 			// since otherwise they'll interfere with the count