www

commit c925c6bf0191b0c90523a94b2889e3c2ee030060
parent 0cabc88378fee616e5bca8a7854ab2e924b9b22f
Author: Dan Stillman <dstillman@zotero.org>
Date:   Wed, 30 Aug 2006 21:34:51 +0000

Fixes #229, Deleting multiple items shows "selected item" warning


Diffstat:
M
chrome/chromeFiles/content/scholar/overlay.js
 | 
18
++++++++++++++----

1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/chrome/chromeFiles/content/scholar/overlay.js b/chrome/chromeFiles/content/scholar/overlay.js
@@ -265,17 +265,27 @@ var ScholarPane = new function()
 			{
 				var start = new Object();
 				var end = new Object();
-				for (var i=0, len=itemsView.selection.getRangeCount(); i<len && !hasChildren; i++)
+				for (var i=0, len=itemsView.selection.getRangeCount(); i<len; i++)
 				{
 					itemsView.selection.getRangeAt(i,start,end);
-					for (var j=start.value; j<=end.value && !hasChildren; j++)
-						if(itemsView._getItemAtRow(j).numChildren())
+					for (var j=start.value; j<=end.value; j++)
+						if (itemsView._getItemAtRow(j).numChildren())
+						{
 							hasChildren = true;
+							break;
+						}
 				}
 			}
 
-			if(promptService.confirmCheck(window, Scholar.getString('pane.items.delete.title'), Scholar.getString('pane.items.delete'), ( hasChildren ? Scholar.getString('pane.items.delete.attached') : ''), eraseChildren))
+			if (promptService.confirmCheck(
+				window,
+				Scholar.getString('pane.items.delete.title'),
+				Scholar.getString('pane.items.delete' + (itemsView.selection.count>1 ? '.multiple' : '')),
+				hasChildren ? Scholar.getString('pane.items.delete.attached') : '',
+				eraseChildren))
+			{
 				itemsView.deleteSelection(eraseChildren.value);
+			}
 		}
 	}