www

commit 8fce17c152b3ac027901af3e4ca0d64ffe719685
parent 04e35919771c88b722227f3f6481362f4dfc8492
Author: Avram Lyon <ajlyon@gmail.com>
Date:   Sun, 29 May 2011 05:47:16 +0000

Trans:‌ Rename IMDb, switch to proper selectItems callback


Diffstat:
D
translators/IMDB.js
 | 
115
-------------------------------------------------------------------------------
A
translators/IMDb.js
 | 
123
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

2 files changed, 123 insertions(+), 115 deletions(-)
diff --git a/translators/IMDB.js b/translators/IMDB.js
@@ -1,115 +0,0 @@
-{
-        "translatorID": "a30274ac-d3d1-4977-80f4-5320613226ec",
-        "label": "IMDB",
-        "creator": "Avram Lyon",
-        "target": "^https?://www\\.imdb\\.com/",
-        "minVersion": "2.1",
-        "maxVersion": "",
-        "priority": 100,
-        "inRepository": true,
-        "translatorType": 4,
-        "lastUpdated": "2011-05-28 14:17:44"
-}
-
-/*
-   IMDB Translator
-   Copyright (C) 2011 Avram Lyon, ajlyon@gmail.com
-
-   This program is free software: you can redistribute it and/or modify
-   it under the terms of the GNU General Public License as published by
-   the Free Software Foundation, either version 3 of the License, or
-   (at your option) any later version.
-
-   This program is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-   GNU General Public License for more details.
-
-   You should have received a copy of the GNU General Public License
-   along with this program.  If not, see <http://www.gnu.org/licenses/>.
-*/
-
-function detectWeb(doc, url){
-	if (url.match(/\/title\/tt\d+/)) {
-		return "film";
-	} else if (url.match(/\/find\?/)){
-		return "multiple";
-	}
-}
-
-function doWeb(doc, url){
-	var n = doc.documentElement.namespaceURI;
-	var ns = n ? function(prefix) {
-		if (prefix == 'x') return n; else return null;
-	} : null;
-	
-	var ids = new Array();
-	if (detectWeb(doc, url) == "multiple") {
-		var results = doc.evaluate('//td[a[contains(@href,"/title/tt")]]', doc, ns, XPathResult.ANY_TYPE, null);
-		var items = new Array();
-		var result;
-		while(result = results.iterateNext()) {
-			var link = doc.evaluate('./a[contains(@href,"/title/tt")]', result, ns, XPathResult.ANY_TYPE, null).iterateNext();
-			var title = result.textContent;
-			Zotero.debug(link.href);
-			var url = link.href.match(/\/title\/(tt\d+)/)[1];
-			items[url] = title;
-		}
-		items = Zotero.selectItems(items);
-		if(!items) return true;
-		for (var i in items) {
-			ids.push(i);
-		}
-	} else {
-		var id = url.match(/\/title\/(tt\d+)/)[1];
-		ids = [id];
-	}
-	
-	apiFetch(ids);	
-}
-
-// Takes IMDB IDs and makes items
-function apiFetch(ids) {
-	var apiRoot = "http://imdbapi.com/?tomatoes=true&i=";
-	for (i in ids) ids[i] = apiRoot + ids[i];
-	Zotero.Utilities.doGet(ids, parseIMDBapi, function() {Zotero.done()});
-	Zotero.wait();
-}
-
-// parse result from imdbapi.com
-// should be json
-function parseIMDBapi(text, response, url) {
-	Zotero.debug(url);
-	Zotero.debug(text);
-	try {
-		var obj = JSON.parse(text);
-	} catch (e) {
-		Zotero.debug("JSON parse error");
-		throw e;
-	}
-	var item = new Zotero.Item("film");
-	item.title = obj.Title;
-	item.date = obj.Released ? obj.Released : obj.Year;
-	item.genre = obj.Genre;
-	if(obj.Director) item = addCreator(item, obj.Director, "director");	
-	if(obj.Writer) item = addCreator(item, obj.Writer, "scriptwriter");
-	if(obj.Actors) item = addCreator(item, obj.Actors, "contributor");
-	item.abstractNote = obj.Plot;
-	item.attachments.push({url:obj.Poster, title:"Poster"});
-	item.runningTime = obj.Runtime;
-	item.extra = "IMDB ID: " + obj.ID;
-	item.extra += "; IMDB Rating: " + obj.Rating + " ("+obj.Votes+" votes)";
-	item.extra += "; Rotten Tomatoes: " + obj.tomatoRating
-				 + " ("+obj.tomatoReviews+" reviews "
-				 +" "+obj.tomatoFresh +" fresh, "+obj.tomatoRotten+" rotten)"
-				 +", Tomato Meter: "+obj.tomatoMeter;
-	item.complete();
-}
-
-function addCreator (item, creator, type) {
-	var broken = creator.split(",");
-	for (i in broken) {
-		item.creators.push(Zotero.Utilities.cleanAuthor(broken[i], type));
-	}
-	return item;
-}
diff --git a/translators/IMDb.js b/translators/IMDb.js
@@ -0,0 +1,123 @@
+{
+        "translatorID": "a30274ac-d3d1-4977-80f4-5320613226ec",
+        "label": "IMDb",
+        "creator": "Avram Lyon",
+        "target": "^https?://www\\.imdb\\.com/",
+        "minVersion": "2.1",
+        "maxVersion": "",
+        "priority": 100,
+        "inRepository": true,
+        "translatorType": 4,
+        "lastUpdated": "2011-05-29 09:44:03"
+}
+
+/*
+   IMDB Translator
+   Copyright (C) 2011 Avram Lyon, ajlyon@gmail.com
+
+   This program is free software: you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation, either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+*/
+
+function detectWeb(doc, url){
+	if (url.match(/\/title\/tt\d+/)) {
+		return "film";
+	} else if (url.match(/\/find\?/)){
+		return "multiple";
+	}
+}
+
+function doWeb(doc, url){
+	var n = doc.documentElement.namespaceURI;
+	var ns = n ? function(prefix) {
+		if (prefix == 'x') return n; else return null;
+	} : null;
+	
+	var ids = new Array();
+	if (detectWeb(doc, url) == "multiple") {
+		var results = doc.evaluate('//td[a[contains(@href,"/title/tt")]]', doc, ns, XPathResult.ANY_TYPE, null);
+		var items = new Array();
+		var result;
+		while(result = results.iterateNext()) {
+			var link = doc.evaluate('./a[contains(@href,"/title/tt")]', result, ns, XPathResult.ANY_TYPE, null).iterateNext();
+			var title = result.textContent;
+			Zotero.debug(link.href);
+			var url = link.href.match(/\/title\/(tt\d+)/)[1];
+			items[url] = title;
+		}
+		
+		Zotero.selectItems(items, function(items) {
+			if(!items) {
+				Zotero.done();
+				return true;
+			}
+			for (var i in items) {
+				ids.push(i);
+			}
+			apiFetch(ids);
+		});
+	} else {
+		var id = url.match(/\/title\/(tt\d+)/)[1];
+		apiFetch([id]);
+	}
+	Zotero.wait();
+}
+
+// Takes IMDB IDs and makes items
+function apiFetch(ids) {
+	var apiRoot = "http://imdbapi.com/?tomatoes=true&i=";
+	for (i in ids) ids[i] = apiRoot + ids[i];
+	Zotero.Utilities.doGet(ids, parseIMDBapi, function() {Zotero.done()});
+}
+
+// parse result from imdbapi.com
+// should be json
+function parseIMDBapi(text, response, url) {
+	Zotero.debug(url);
+	Zotero.debug(text);
+	try {
+		var obj = JSON.parse(text);
+	} catch (e) {
+		Zotero.debug("JSON parse error");
+		throw e;
+	}
+	var item = new Zotero.Item("film");
+	item.title = obj.Title;
+	item.date = obj.Released ? obj.Released : obj.Year;
+	item.genre = obj.Genre;
+	if(obj.Director) item = addCreator(item, obj.Director, "director");	
+	if(obj.Writer) item = addCreator(item, obj.Writer, "scriptwriter");
+	if(obj.Actors) item = addCreator(item, obj.Actors, "contributor");
+	item.abstractNote = obj.Plot;
+	item.attachments.push({url:obj.Poster, title:"Poster"});
+	item.runningTime = obj.Runtime;
+	item.extra = "IMDB ID: " + obj.ID;
+	item.extra += "; IMDB Rating: " + obj.Rating + " ("+obj.Votes+" votes)";
+	item.extra += "; Rotten Tomatoes: " + obj.tomatoRating
+				 + " ("+obj.tomatoReviews+" reviews "
+				 +" "+obj.tomatoFresh +" fresh, "+obj.tomatoRotten+" rotten)"
+				 +", Tomato Meter: "+obj.tomatoMeter;
+	item.complete();
+}
+
+function addCreator (item, creator, type) {
+	if (creator == "N/A") {
+		Zotero.debug("Discarding "+type+"="+creator);
+		return item;
+	}
+	var broken = creator.split(",");
+	for (i in broken) {
+		item.creators.push(Zotero.Utilities.cleanAuthor(broken[i], type));
+	}
+	return item;
+}