www

commit 8e3b1615bfae661ee5f0a0a5479d9cf3a158c583
parent eb9597489132ce7335283b62cb720aca7fa86f4b
Author: Dan Stillman <dstillman@zotero.org>
Date:   Thu, 16 Sep 2010 15:50:53 +0000

Throw plugin incompatibility error properly


Diffstat:
M
chrome/content/zotero/xpcom/integration.js
 | 
10
++++++----

1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/chrome/content/zotero/xpcom/integration.js b/chrome/content/zotero/xpcom/integration.js
@@ -190,12 +190,14 @@ Zotero.Integration = new function() {
 					_inProgress = false;
 					_integrationVersionsOK = false;
 					Zotero.Integration.activate();
+					var msg = Zotero.getString(
+						"integration.error.incompatibleVersion2",
+						[Zotero.version, addon.name, INTEGRATION_MIN_VERSION]
+					);
 					Components.classes["@mozilla.org/embedcomp/prompt-service;1"]
 						.getService(Components.interfaces.nsIPromptService)
-						.alert(null, Zotero.getString("integration.error.title"),
-							Zotero.getString("integration.error.incompatibleVersion2", [Zotero.version, 
-								addon.name, INTEGRATION_MIN_VERSION]));
-					throw e;
+						.alert(null, Zotero.getString("integration.error.title"), msg);
+					throw msg;
 				}
 			}
 			_integrationVersionsOK = true;