www

commit 7a93b132b348ebb1c6634d8f83ab95dff0f209ee
parent 7761335bc7f1c9d0aa2daccbfa76efdd318af6c0
Author: Dan Stillman <dstillman@zotero.org>
Date:   Thu, 14 May 2015 13:10:20 -0400

Merge pull request #715 from rmzelle/proxylist-editbutton

Add Edit button to proxy list
Diffstat:
M
chrome/content/zotero/preferences/preferences_firefox.xul
 | 
11
++++++++---
M
chrome/content/zotero/preferences/preferences_proxies.js
 | 
9
+++++++++

2 files changed, 17 insertions(+), 3 deletions(-)
diff --git a/chrome/content/zotero/preferences/preferences_firefox.xul b/chrome/content/zotero/preferences/preferences_firefox.xul
@@ -23,7 +23,10 @@
     
     ***** END LICENSE BLOCK *****
 -->
-<!DOCTYPE prefwindow SYSTEM "chrome://zotero/locale/preferences.dtd">
+<!DOCTYPE prefwindow [
+	<!ENTITY % preferencesDTD SYSTEM "chrome://zotero/locale/preferences.dtd"> %preferencesDTD;
+	<!ENTITY % zoteroDTD SYSTEM "chrome://zotero/locale/zotero.dtd"> %zoteroDTD;
+]>
 
 <?xml-stylesheet href="chrome://global/skin/global.css"?>
 <?xml-stylesheet href="chrome://browser/skin/preferences/preferences.css"?>
@@ -64,7 +67,7 @@
 				<caption label="&zotero.preferences.proxies.configured;"/>
 				
 				<tree id="proxyTree" hidecolumnpicker="true" rows="6" seltype="single"
-						ondblclick="Zotero_Preferences.Proxies.showProxyEditor(this.currentIndex)" onselect="document.getElementById('proxyTree-delete').disabled = undefined"
+						ondblclick="Zotero_Preferences.Proxies.showProxyEditor(this.currentIndex)" onselect="Zotero_Preferences.Proxies.enableProxyButtons()"
 						onkeypress="if (event.keyCode == event.DOM_VK_DELETE) { Zotero_Preferences.Proxies.deleteProxy(); }">
 					<treecols>
 						<treecol id="proxyTree-hostname" label="&zotero.preferences.proxies.hostname;" flex="1"/>
@@ -73,7 +76,9 @@
 					<treechildren id="proxyTree-rows"/>
 				</tree>
 				<separator class="thin"/>
-				<hbox pack="end">
+				<hbox>
+					<button disabled="true" id="proxyTree-edit" label="&zotero.general.edit;" onclick="Zotero_Preferences.Proxies.showProxyEditor(document.getElementById('proxyTree').currentIndex)"/>
+					<spacer flex="1"/>
 					<button disabled="true" id="proxyTree-delete" label="-" onclick="Zotero_Preferences.Proxies.deleteProxy()"/>
 					<button label="+" id="proxyTree-add" onclick="Zotero_Preferences.Proxies.showProxyEditor()"/>
 				</hbox>
diff --git a/chrome/content/zotero/preferences/preferences_proxies.js b/chrome/content/zotero/preferences/preferences_proxies.js
@@ -56,6 +56,14 @@ Zotero_Preferences.Proxies = {
 	
 	
 	/**
+	 * Enables UI buttons when proxy is selected
+	 */
+	enableProxyButtons: function () {
+		document.getElementById('proxyTree-edit').disabled = false;
+		document.getElementById('proxyTree-delete').disabled = false;
+	},
+	
+	/**
 	 * Adds a proxy to the proxy pane
 	 */
 	showProxyEditor: function (index) {
@@ -138,6 +146,7 @@ Zotero_Preferences.Proxies = {
 		}
 		
 		document.getElementById('proxyTree').currentIndex = -1;
+		document.getElementById('proxyTree-edit').disabled = true;
 		document.getElementById('proxyTree-delete').disabled = true;
 		document.getElementById('zotero-proxies-transparent').checked = Zotero.Prefs.get("proxies.transparent");
 		document.getElementById('zotero-proxies-autoRecognize').checked = Zotero.Prefs.get("proxies.autoRecognize");