www

commit 7633c7de3047db0f9afcaaf395ee6d43235b2938
parent 88627adcdb53d0c862914b305f7ecf378b4ab29b
Author: Dan Stillman <dstillman@zotero.org>
Date:   Tue, 29 Sep 2015 04:07:26 -0400

Set test timeout in resetDB() instead of separate this.timeout() calls

'thisArg: this' should be passed to resetDB to have it adjust the
timeout

Diffstat:
M
test/content/support.js
 | 
3
+++
M
test/tests/supportTest.js
 | 
5
+++--
M
test/tests/syncEngineTest.js
 | 
7
++++---
M
test/tests/syncRunnerTest.js
 | 
7
++++---

4 files changed, 14 insertions(+), 8 deletions(-)
diff --git a/test/content/support.js b/test/content/support.js
@@ -426,6 +426,9 @@ var getTempDirectory = Zotero.Promise.coroutine(function* getTempDirectory() {
  *                             any that were set at startup
  */
 function resetDB(options = {}) {
+	if (options.thisArg) {
+		options.thisArg.timeout(60000);
+	}
 	var db = Zotero.getZoteroDatabase();
 	return Zotero.reinit(function() {
 		db.remove(false);
diff --git a/test/tests/supportTest.js b/test/tests/supportTest.js
@@ -1,8 +1,9 @@
 describe("Support Functions for Unit Testing", function() {
 	describe("resetDB", function() {
 		it("should restore the DB to factory settings", function* () {
-			this.timeout(60000);
-			yield resetDB();
+			yield resetDB({
+				thisArg: this
+			});
 			assert.equal((yield Zotero.DB.valueQueryAsync("SELECT COUNT(*) FROM items")), 0);
 		});
 	});
diff --git a/test/tests/syncEngineTest.js b/test/tests/syncEngineTest.js
@@ -108,8 +108,8 @@ describe("Zotero.Sync.Data.Engine", function () {
 	// Tests
 	//
 	beforeEach(function* () {
-		this.timeout(60000);
 		yield resetDB({
+			thisArg: this,
 			skipBundledFiles: true
 		});
 		
@@ -119,8 +119,9 @@ describe("Zotero.Sync.Data.Engine", function () {
 		yield Zotero.Users.setCurrentUsername("testuser");
 	})
 	after(function* () {
-		this.timeout(60000);
-		yield resetDB();
+		yield resetDB({
+			thisArg: this
+		});
 	})
 	
 	describe("Syncing", function () {
diff --git a/test/tests/syncRunnerTest.js b/test/tests/syncRunnerTest.js
@@ -445,16 +445,17 @@ describe("Zotero.Sync.Runner", function () {
 	
 	describe("#sync()", function () {
 		before(function* () {
-			this.timeout(60000);
 			yield resetDB({
+				thisArg: this,
 				skipBundledFiles: true
 			});
 			
 			yield Zotero.Libraries.init();
 		})
 		after(function* () {
-			this.timeout(60000);
-			yield resetDB();
+			yield resetDB({
+				thisArg: this
+			});
 		})
 		
 		it("should perform a sync across all libraries", function* () {