www

commit 66a6272adc0e16f428194052efa06ca5997066a8
parent 276cd82fe4c5032b63cb11cc147b028f1ba382ee
Author: Dan Stillman <dstillman@zotero.org>
Date:   Fri, 30 Jan 2015 00:45:24 -0500

Merge pull request #621 from aurimasv/api_syncing-bugfix

[API syncing] Minor bugfixes
Diffstat:
M
chrome/content/zotero/xpcom/collectionTreeView.js
 | 
4
++--
M
chrome/content/zotero/xpcom/data/items.js
 | 
5
+----
M
chrome/content/zotero/xpcom/itemTreeView.js
 | 
4
++++

3 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/chrome/content/zotero/xpcom/collectionTreeView.js b/chrome/content/zotero/xpcom/collectionTreeView.js
@@ -184,9 +184,9 @@ Zotero.CollectionTreeView.prototype.refresh = Zotero.Promise.coroutine(function*
 						rows,
 						new Zotero.CollectionTreeRow('group', groups[i]),
 						1,
-						beforeRow ? beforeRow + i + newRows : null
+						beforeRow ? beforeRow + newRows : null
 					);
-					newRows += yield self._expandRow(rows, row);
+					newRows += 1 + ( yield self._expandRow(rows, row) );
 				}
 				return newRows;
 			})
diff --git a/chrome/content/zotero/xpcom/data/items.js b/chrome/content/zotero/xpcom/data/items.js
@@ -256,9 +256,6 @@ Zotero.Items = function() {
 			if (this.isPrimaryField(field)) {
 				primaryFields.push(field);
 			}
-			else if (field == 'itemType') {
-				primaryFields.push('itemTypeID');
-			}
 			else {
 				fieldIDs.push(Zotero.ItemFields.getID(field));
 				if (Zotero.ItemFields.isBaseField(field)) {
@@ -288,7 +285,7 @@ Zotero.Items = function() {
 						}
 						Zotero.debug(obj.itemID);
 						Zotero.debug(Object.keys(this._objectCache));
-						this._objectCache[obj.itemID].loadFromRow(rowObj);
+						this._objectCache[obj.itemID].loadFromRow(obj);
 					}.bind(this)
 				}
 			);
diff --git a/chrome/content/zotero/xpcom/itemTreeView.js b/chrome/content/zotero/xpcom/itemTreeView.js
@@ -302,6 +302,10 @@ Zotero.ItemTreeView.prototype.refresh = Zotero.serial(Zotero.Promise.coroutine(f
 			case 'year':
 				field = 'date';
 				break;
+			
+			case 'itemType':
+				field = 'itemTypeID';
+				break;
 		}
 		if (cacheFields.indexOf(field) == -1) {
 			cacheFields = cacheFields.concat(field);