commit 59edca783e2b2cff520b2af9e986315ab8b21ea3
parent 91512469d5b1a74b755bf7b8f49dea135b1ca4cb
Author: Dan Stillman <dstillman@zotero.org>
Date: Sun, 9 Jul 2017 05:49:02 -0400
Allow dragging onto welcome text
Diffstat:
3 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/chrome/content/zotero/xpcom/itemTreeView.js b/chrome/content/zotero/xpcom/itemTreeView.js
@@ -1765,6 +1765,8 @@ Zotero.ItemTreeView.prototype._updateIntroText = function() {
};
}
}
+
+ div.setAttribute('allowdrop', true);
}
// My Publications
else if (this.collectionTreeRow.isPublications()) {
diff --git a/chrome/content/zotero/xpcom/libraryTreeView.js b/chrome/content/zotero/xpcom/libraryTreeView.js
@@ -328,7 +328,17 @@ Zotero.LibraryTreeView.prototype = {
var target = event.target;
if (target.tagName != 'treechildren') {
- return false;
+ let doc = target.ownerDocument;
+ // Consider a drop on the items pane message box (e.g., when showing the welcome text)
+ // a drop on the items tree
+ let msgBox = doc.getElementById('zotero-items-pane-message-box');
+ if (msgBox.contains(target) && msgBox.firstChild.hasAttribute('allowdrop')) {
+ target = doc.querySelector('#zotero-items-tree treechildren');
+ }
+ else {
+ this._setDropEffect(event, "none");
+ return false;
+ }
}
var tree = target.parentNode;
let row = {}, col = {}, obj = {};
diff --git a/chrome/content/zotero/zoteroPane.xul b/chrome/content/zotero/zoteroPane.xul
@@ -565,7 +565,10 @@
<!-- Label for displaying messages when items pane is hidden
(e.g. "Advanced search mode — press Enter to search.")-->
- <vbox id="zotero-items-pane-message-box" pack="center" align="center"/>
+ <vbox id="zotero-items-pane-message-box" pack="center" align="center"
+ ondragenter="return ZoteroPane.itemsView.onDragEnter(event)"
+ ondragover="return ZoteroPane.itemsView.onDragOver(event)"
+ ondrop="ZoteroPane.itemsView.onDrop(event); ZoteroPane.itemsView.drop(-1, -1, event.dataTransfer)"/>
</deck>
</vbox>