www

Unnamed repository; edit this file 'description' to name the repository.
Log | Files | Refs | Submodules | README | LICENSE

commit 5236d01791f36f2758675d437ebe22ad168d7f4a
parent 9b247ebba7cfb11e7b8547cff03a1be223414adc
Author: Dan Stillman <dstillman@zotero.org>
Date:   Sat, 21 Jan 2017 06:33:36 -0500

Fix mangled large reports

https://forums.zotero.org/discussion/64022/5-0-beta-generate-report-is-often-garbled

Records are being truncated, though I'm not sure why. But just read the input
stream into a string for now.

Diffstat:
Mcomponents/zotero-protocol-handler.js | 16+++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/components/zotero-protocol-handler.js b/components/zotero-protocol-handler.js @@ -444,12 +444,26 @@ function ZoteroProtocolHandler() { default: this.contentType = 'text/html'; - return Zotero.Utilities.Internal.getAsyncInputStream( + + // DEBUG: Results in mangled reports + // + // https://forums.zotero.org/discussion/64022/5-0-beta-generate-report-is-often-garbled + /*return Zotero.Utilities.Internal.getAsyncInputStream( + Zotero.Report.HTML.listGenerator(items, combineChildItems), + function () { + return '<span style="color: red; font-weight: bold">Error generating report</span>'; + } + );*/ + + Components.utils.import("resource://gre/modules/NetUtil.jsm"); + var is = Zotero.Utilities.Internal.getAsyncInputStream( Zotero.Report.HTML.listGenerator(items, combineChildItems), function () { return '<span style="color: red; font-weight: bold">Error generating report</span>'; } ); + var str = NetUtil.readInputStreamToString(is, is.available(), {}); + return Zotero.Promise.resolve(str); } }); }