www

commit 4df28f93cbcda5659b33de9ee4db474c892a4571
parent e531493ba05e5f4ecf0308e494beddac368db8e6
Author: Simon Kornblith <simon@simonster.com>
Date:   Sat,  6 Nov 2010 21:35:06 +0000

don't use getters, since they probably don't save much memory and they don't seem to work with Fx3.6 wrappers


Diffstat:
M
chrome/content/zotero/xpcom/translation/item_local.js
 | 
10
+++-------

1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/chrome/content/zotero/xpcom/translation/item_local.js b/chrome/content/zotero/xpcom/translation/item_local.js
@@ -623,10 +623,6 @@ Zotero.Translate.ItemGetter.prototype = {
 	 * Converts an item to array format
 	 */
 	"_itemToArray":function(returnItem) {
-		const makeGetter = function(returnItemArray, fieldName) {
-			return function() { return returnItemArray[fieldName] };
-		}
-		
 		// TODO use Zotero.Item#serialize()
 		var returnItemArray = returnItem.toArray();
 		
@@ -652,10 +648,10 @@ Zotero.Translate.ItemGetter.prototype = {
 				}
 				
 				if(baseName) {
-					returnItemArray.__defineGetter__(baseName, makeGetter(returnItemArray, fieldName));
-					returnItemArray.uniqueFields.__defineGetter__(baseName, makeGetter(returnItemArray, fieldName));
+					returnItemArray[baseName] = returnItemArray[fieldName];
+					returnItemArray.uniqueFields[baseName] = returnItemArray[fieldName];
 				} else {
-					returnItemArray.uniqueFields.__defineGetter__(fieldName, makeGetter(returnItemArray, fieldName));
+					returnItemArray.uniqueFields[fieldName] = returnItemArray[fieldName];
 				}
 			}
 		}