www

commit 450f15cda72d31e1f3531a9f4a059956e58e94dc
parent 57fe0f65ee22faeca23090bc2449f6dfb6bd7e14
Author: Simon Kornblith <simon@simonster.com>
Date:   Mon, 11 Jun 2012 00:26:47 -0400

Fix a typo in previous commit and guard against attempts to import from clipboard into a read-only collection (although eventually we should just disable the menu item)

Diffstat:
M
chrome/content/zotero/fileInterface.js
 | 
30
+++++++++++++++++-------------

1 file changed, 17 insertions(+), 13 deletions(-)
diff --git a/chrome/content/zotero/fileInterface.js b/chrome/content/zotero/fileInterface.js
@@ -195,7 +195,17 @@ var Zotero_File_Interface = new function() {
 	/**
 	 * Creates Zotero.Translate instance and shows file picker for file import
 	 */
-	function importFile(file, createNewCollectionOverride) {
+	function importFile(file, createNewCollection) {
+		if(createNewCollection === undefined) {
+			createNewCollection = true;
+		} else if(!createNewCollection) {
+			try {
+				if (!ZoteroPane.collectionsView.editable) {
+					ZoteroPane.collectionsView.selectLibrary(null);
+				}
+			} catch(e) {}
+		}
+		
 		var translation = new Zotero.Translate.Import();
 		if(!file) {
 			var translators = translation.getTranslators();
@@ -218,18 +228,6 @@ var Zotero_File_Interface = new function() {
 			file = fp.file;
 		}
 		
-		var createNewCollection;
-		if(createNewCollectionOverride === undefined) {
-			createNewCollection = true;
-		} else if(!createNewCollectionOverride) {
-			createNewCollection = createNewCollectionOverride;
-			try {
-				if (!ZoteroPane.collectionsView.editable) {
-					ZoteroPane.collectionsView.selectLibrary(null);
-				}
-			} catch(e) {}
-		}
-		
 		translation.setLocation(file);
 		// get translators again, bc now we can check against the file
 		translation.setHandler("translators", function(obj, item) {
@@ -271,6 +269,12 @@ var Zotero_File_Interface = new function() {
 		
 		var translate = new Zotero.Translate.Import();
 		translate.setString(str);
+	
+		try {
+			if (!ZoteroPane.collectionsView.editable) {
+				ZoteroPane.collectionsView.selectLibrary(null);
+			}
+		} catch(e) {}
 		translate.setHandler("translators", function(obj, item) {
 			_importTranslatorsAvailable(obj, item, false); 
 		});