www

commit 40da5f61a0e4428ec9b54b22882f76355bcee359
parent 021cfa8b3b853ebfc4b9f850eccf8859d6db9b5c
Author: Dan Stillman <dstillman@zotero.org>
Date:   Fri,  5 May 2017 03:26:29 -0400

Still process downloads if uploads fail for a library

Diffstat:
M
chrome/content/zotero/xpcom/sync/syncEngine.js
 | 
14
++++++++++++--
M
test/tests/syncEngineTest.js
 | 
53
+++++++++++++++++++++++++++++++++++++++++++++++++++++

2 files changed, 65 insertions(+), 2 deletions(-)
diff --git a/chrome/content/zotero/xpcom/sync/syncEngine.js b/chrome/content/zotero/xpcom/sync/syncEngine.js
@@ -120,8 +120,18 @@ Zotero.Sync.Data.Engine.prototype.start = Zotero.Promise.coroutine(function* () 
 	
 	sync:
 	while (true) {
-		let uploadResult = yield this._startUpload();
-		let downloadResult;
+		let downloadResult, uploadResult;
+		
+		try {
+			uploadResult = yield this._startUpload();
+		}
+		catch (e) {
+			Zotero.debug("Upload failed -- performing download", 2);
+			downloadResult = yield this._startDownload();
+			Zotero.debug("Download result is " + downloadResult, 4);
+			throw e;
+		}
+		
 		Zotero.debug("Upload result is " + uploadResult, 4);
 		
 		switch (uploadResult) {
diff --git a/test/tests/syncEngineTest.js b/test/tests/syncEngineTest.js
@@ -835,6 +835,59 @@ describe("Zotero.Sync.Data.Engine", function () {
 		})
 		
 		
+		it("should process downloads after upload failure", function* () {
+			({ engine, client, caller } = yield setup({
+				stopOnError: false
+			}));
+			
+			var library = Zotero.Libraries.userLibrary;
+			var libraryID = library.id;
+			var lastLibraryVersion = 5;
+			library.libraryVersion = lastLibraryVersion;
+			yield library.saveTx();
+			
+			var collection = yield createDataObject('collection');
+			
+			var called = 0;
+			server.respond(function (req) {
+				if (called == 0) {
+					req.respond(
+						200,
+						{
+							"Last-Modified-Version": lastLibraryVersion
+						},
+						JSON.stringify({
+							successful: {},
+							unchanged: {},
+							failed: {
+								0: {
+									code: 400,
+									message: "Upload failed"
+								}
+							}
+						})
+					);
+				}
+				called++;
+			});
+			
+			var stub = sinon.stub(engine, "_startDownload")
+				.returns(Zotero.Promise.resolve(engine.DOWNLOAD_RESULT_CONTINUE));
+			
+			var e = yield getPromiseError(engine.start());
+			assert.equal(called, 1);
+			// start() should still fail
+			assert.ok(e);
+			assert.equal(e.message, "Made no progress during upload -- stopping");
+			// The collection shouldn't have been marked as synced
+			assert.isFalse(collection.synced);
+			// Download should have been performed
+			assert.ok(stub.called);
+			
+			stub.restore();
+		});
+		
+		
 		it("shouldn't include mtime and md5 for attachments in ZFS libraries", function* () {
 			({ engine, client, caller } = yield setup());