www

commit 2588a0a651fdf434fdccbcd87146184e59c9dea5
parent 5b0b874435146b7b0aae2ee1372a7823bfc0949e
Author: Dan Stillman <dstillman@zotero.org>
Date:   Wed,  3 May 2017 03:54:54 -0400

Simplify deleteCacheObjectVersions() query

Diffstat:
M
chrome/content/zotero/xpcom/sync/syncLocal.js
 | 
7
+++----

1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/chrome/content/zotero/xpcom/sync/syncLocal.js b/chrome/content/zotero/xpcom/sync/syncLocal.js
@@ -1082,10 +1082,9 @@ Zotero.Sync.Data.Local = {
 	 * @param {Integer} [maxVersion]
 	 */
 	deleteCacheObjectVersions: function (objectType, libraryID, key, minVersion, maxVersion) {
-		var sql = "DELETE FROM syncCache WHERE libraryID=? AND key=? "
-			+ "AND syncObjectTypeID IN (SELECT syncObjectTypeID FROM "
-			+ "syncObjectTypes WHERE name=?)";
-		var params = [libraryID, key, objectType];
+		var syncObjectTypeID = Zotero.Sync.Data.Utilities.getSyncObjectTypeID(objectType);
+		var sql = "DELETE FROM syncCache WHERE libraryID=? AND key=? AND syncObjectTypeID=?";
+		var params = [libraryID, key, syncObjectTypeID];
 		if (minVersion && minVersion == maxVersion) {
 			sql += " AND version=?";
 			params.push(minVersion);