www

commit 17119aadd1de11c0fc81ced142297d3414d80d47
parent 0347b576e6af7c979c5dd5b3e6d810e2e121cccc
Author: Dan Stillman <dstillman@zotero.org>
Date:   Thu, 23 Dec 2010 08:08:31 +0000

Use proper collation sort for creators


Diffstat:
M
chrome/content/zotero/xpcom/itemTreeView.js
 | 
7
+++----

1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/chrome/content/zotero/xpcom/itemTreeView.js b/chrome/content/zotero/xpcom/itemTreeView.js
@@ -1030,7 +1030,7 @@ Zotero.ItemTreeView.prototype.sort = function(itemID)
 			return 0;
 		}
 		
-		var cmp = strcmp(fieldA, fieldB);
+		var cmp = strcmp(fieldA, fieldB, true);
 		if (cmp) {
 			return cmp
 		}
@@ -1042,7 +1042,6 @@ Zotero.ItemTreeView.prototype.sort = function(itemID)
 		var bCreators = b.ref.getCreators();
 		var aNumCreators = a.ref.numCreators();
 		var bNumCreators = b.ref.numCreators();
-		var maxCreators = Math.max(aNumCreators, bNumCreators);
 		
 		var aPrimary = Zotero.CreatorTypes.getPrimaryIDForType(a.ref.itemTypeID);
 		var bPrimary = Zotero.CreatorTypes.getPrimaryIDForType(b.ref.itemTypeID);
@@ -1128,14 +1127,14 @@ Zotero.ItemTreeView.prototype.sort = function(itemID)
 			// Compare names
 			fieldA = Zotero.Items.getSortTitle(aCreators[aPos].ref.lastName);
 			fieldB = Zotero.Items.getSortTitle(bCreators[bPos].ref.lastName);
-			var cmp = strcmp(fieldA, fieldB);
+			var cmp = strcmp(fieldA, fieldB, true);
 			if (cmp) {
 				return cmp;
 			}
 			
 			fieldA = Zotero.Items.getSortTitle(aCreators[aPos].ref.firstName);
 			fieldB = Zotero.Items.getSortTitle(bCreators[bPos].ref.firstName);
-			var cmp = strcmp(fieldA, fieldB);
+			var cmp = strcmp(fieldA, fieldB, true);
 			if (cmp) {
 				return cmp;
 			}