commit 078efc4042971a43fadb12613205a797727cf87d parent 9fa7dc524988250f744a0e7f1f630ec592c0b1ba Author: Dan Stillman <dstillman@zotero.org> Date: Thu, 3 Nov 2011 12:46:48 -0400 Don't die if a creator is missing at an index Diffstat:
| M | chrome/content/zotero/xpcom/itemTreeView.js | | | 18 | ++++++++++++++++++ |
1 file changed, 18 insertions(+), 0 deletions(-)
diff --git a/chrome/content/zotero/xpcom/itemTreeView.js b/chrome/content/zotero/xpcom/itemTreeView.js @@ -1266,6 +1266,15 @@ Zotero.ItemTreeView.prototype.sort = function(itemID) aPos++; var aFound = false; while (aPos < aNumCreators) { + // Don't die if there's no creator at an index + if (!aCreators[aPos]) { + Components.utils.reportError( + "Creator is missing at position " + aPos + + " for item " + a.ref.libraryID + "/" + a.ref.key + ); + return -1; + } + if (aCreators[aPos].creatorTypeID == aFirstCreatorTypeID) { aFound = true; break; @@ -1276,6 +1285,15 @@ Zotero.ItemTreeView.prototype.sort = function(itemID) bPos++; var bFound = false; while (bPos < bNumCreators) { + // Don't die if there's no creator at an index + if (!bCreators[bPos]) { + Components.utils.reportError( + "Creator is missing at position " + bPos + + " for item " + b.ref.libraryID + "/" + b.ref.key + ); + return -1; + } + if (bCreators[bPos].creatorTypeID == bFirstCreatorTypeID) { bFound = true; break;